- 
                Notifications
    You must be signed in to change notification settings 
- Fork 55
feat: mos status flow rework #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            Julusian
  wants to merge
  11
  commits into
  Sofie-Automation:release53
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
bbc:upstream/mos-status-flow-rework
  
      
      
   
  
    
  
  
  
 
  
      
    base: release53
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            feat: mos status flow rework #1356
                    Julusian
  wants to merge
  11
  commits into
  Sofie-Automation:release53
from
bbc:upstream/mos-status-flow-rework
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@              Coverage Diff              @@
##           release53    #1356      +/-   ##
=============================================
+ Coverage      56.87%   57.30%   +0.42%     
=============================================
  Files            404      437      +33     
  Lines          73147    79354    +6207     
  Branches        4041     4533     +492     
=============================================
+ Hits           41603    45473    +3870     
- Misses         31410    33747    +2337     
  Partials         134      134              ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
573389a    to
    2238ae3      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Feature
Current Behavior
Reporting statuses to a MOS NRCS is quite basic, limited to just sending
PLAYevents for stories as they are taken.New Behavior
The status reporting is overhauled to support a full range of statuses, driven from both playback and ingest.
Additionally, status can now be reported for items as well as the stories.
To do this, a new custom publication has been added to be consumed by the MOS gateway. This publication is slightly mos based (the status levels it contains is based upon MOS), but it intended to be usable for other types of ingest gateways and NRCS systems.
This publication contains documents which follows a similar structure to an
IngestRundown. Each 'Part' in this structure corresponds with a story/part as reported by the gateway. This 'Part' contains a few values which describe the status of the story and of any items. At this level it still reflects the raw values as provided by the playout and ingest logic, they have not been resolved into a single string/value at this point.It is expected that the gateway will get an update to this document for each take performed, as the playback status of parts will change, as well as following any ingest operation.
Inside the gateway, we consume this publication and upon receiving a new version of it perform a diff. Through this, we compile a sequence of MOS messages we should send to report the correct status.
To ensure correct operation, at startup of the gateway, the gateway will write all the values to the NRCS, to ensure they are in sync.
As part of this, the MOS gateway has gained a few new options, to configure how this status writing is performed.
One of these options is to limit the diff to only produce
PLAYstatuses, so that it can be configured to match existing behaviour.Testing
This has been tested against a non-production like openmedia installation. Testing against a production like openmedia has not been done yet, and no testing has been performed against other MOS systems.
This will want testing by NRK to ensure it produces PLAY messages in a way that is compatible with your existing workflow.
Affected areas
This PR affects the status reporting to MOS NRCS
Time Frame
Not urgent, but we would like to get this merged into the in-development release.
Other Information
Status