Skip to content

SONARJAVA-6330 Lower rule S8692's severity and do not raise on System.currentTimeMillis()#5628

Merged
aurelien-coet-sonarsource merged 1 commit into
masterfrom
ac/SONARJAVA-6330
May 22, 2026
Merged

SONARJAVA-6330 Lower rule S8692's severity and do not raise on System.currentTimeMillis()#5628
aurelien-coet-sonarsource merged 1 commit into
masterfrom
ac/SONARJAVA-6330

Conversation

@aurelien-coet-sonarsource
Copy link
Copy Markdown
Contributor

@aurelien-coet-sonarsource aurelien-coet-sonarsource commented May 22, 2026


Summary by Gitar

  • Rule S8692 severity lowered:
    • Changed defaultSeverity from "Critical" to "Major" in rule configuration
    • Updated impact levels: MAINTAINABILITY from "HIGH" to "MEDIUM", RELIABILITY from "MEDIUM" to "LOW"
  • System.currentTimeMillis() exemption:
    • Rule no longer raises on System.currentTimeMillis() calls; marked as compliant for measuring elapsed time in tests
  • Test expectations updated:
    • Removed noncompliant violations from SystemClockCheckSample.java and ruling test files reflecting new rule behavior

This will update automatically on new commits.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod Bot commented May 22, 2026

SONARJAVA-6330

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 22, 2026

Code Review ✅ Approved

Lowers rule S8692 severity from Critical to Major and exempts System.currentTimeMillis() calls from violations, recognizing its valid use for measuring elapsed time in tests. Test expectations updated to reflect the new rule behavior.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@aurelien-coet-sonarsource aurelien-coet-sonarsource marked this pull request as ready for review May 22, 2026 14:21
@aurelien-coet-sonarsource aurelien-coet-sonarsource merged commit 91bd32b into master May 22, 2026
18 checks passed
@aurelien-coet-sonarsource aurelien-coet-sonarsource deleted the ac/SONARJAVA-6330 branch May 22, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants