Skip to content

SONARJAVA-6389 Modify quickfix for S8694: replace == with .equals#5637

Merged
NoemieBenard merged 3 commits into
masterfrom
nb/sonarjava-6389-1
May 28, 2026
Merged

SONARJAVA-6389 Modify quickfix for S8694: replace == with .equals#5637
NoemieBenard merged 3 commits into
masterfrom
nb/sonarjava-6389-1

Conversation

@NoemieBenard
Copy link
Copy Markdown
Contributor

@NoemieBenard NoemieBenard commented May 28, 2026


Summary by Gitar

  • Refactored QuickFix logic:
    • Added parentheses to NOT_EQUAL_TO expressions in DateEnumsCheck to ensure correct operator precedence in replacements.

This will update automatically on new commits.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod Bot commented May 28, 2026

SONARJAVA-6389

Copy link
Copy Markdown
Contributor

@aurelien-coet-sonarsource aurelien-coet-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqube-next
Copy link
Copy Markdown

@NoemieBenard NoemieBenard merged commit dcaed1f into master May 28, 2026
15 checks passed
@NoemieBenard NoemieBenard deleted the nb/sonarjava-6389-1 branch May 28, 2026 11:50
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 28, 2026

Code Review ✅ Approved

Updates the S8694 quickfix to use .equals() instead of == for object comparison, ensuring more robust equality checks. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants