Skip to content

SONARJAVA-6406 Create rule S8714 - Use assertThrows/assertDoesNotThrow instead of try-catch with fail() #5642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rombirli wants to merge 29 commits into
base: master
Choose a base branch
from
+776 −32
Open

SONARJAVA-6406 Create rule S8714 - Use assertThrows/assertDoesNotThrow instead of try-catch with fail() #5642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
d70283d
Add rule S8714 metadata
rombirli May 28, 2026
9a85344
Reproducer
rombirli May 28, 2026
9a9472d
Initial implementation
rombirli May 29, 2026
ce2d0e0
Initial implementation
rombirli May 29, 2026
f2509b7
Initial implementation
rombirli May 29, 2026
44eb21a
Improve sample (more reproducers)
rombirli May 29, 2026
967e985
Fix QG: issue import explicitly
rombirli May 29, 2026
21d25ec
Fix wrong message if fail is in try block
rombirli May 29, 2026
fc94bcf
Update metadata
rombirli May 29, 2026
281facd
Fix ruling/plugin?
rombirli May 29, 2026
0cb3ee1
Fix ruling/autoscan?
rombirli May 29, 2026
5cbed86
Fix ruling/autoscan?
rombirli May 29, 2026
3c0d660
Fix ruling/autoscan?
rombirli May 29, 2026
450d83a
add s8714.json for ruling tests
rombirli Jun 1, 2026
9cb685a
try to fix : autoscan
rombirli Jun 1, 2026
d853a9e
try to fix : ruling
rombirli Jun 1, 2026
61f1092
try to fix : ruling
rombirli Jun 1, 2026
8ec908d
try to fix : ruling
rombirli Jun 1, 2026
15c3acf
try to fix : ruling
rombirli Jun 1, 2026
6f6d306
Fix : Misleading comment says 'non-compliant' for compliant code
rombirli Jun 1, 2026
7deeaf2
Revert useless changes
rombirli Jun 1, 2026
dc100b9
Change issue location (whole try catch)
rombirli Jun 1, 2026
f2d37f0
Change issue location again (report on fail())
rombirli Jun 1, 2026
1878d4c
Remove unused import
rombirli Jun 1, 2026
5014a34
Revert import java.util with wildcard
rombirli Jun 1, 2026
7496d39
Fix ruling eclipse-jetty-similar-to-main S8714 json
rombirli Jun 1, 2026
f743366
Make S8714 junit version aware (only 5+)
rombirli Jun 1, 2026
9adff21
Fix QG
rombirli Jun 1, 2026
1e76072
Address Gitar's review
rombirli Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S1874.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"ruleKey": "S1874",
"hasTruePositives": true,
"falseNegatives": 245,
"falseNegatives": 246,
"falsePositives": 0
}
}
4 changes: 2 additions & 2 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S5960.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"ruleKey": "S5960",
"hasTruePositives": false,
"falseNegatives": 3,
"falseNegatives": 4,
"falsePositives": 0
}
}
6 changes: 6 additions & 0 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S8714.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"ruleKey": "S8714",
"hasTruePositives": false,
"falseNegatives": 33,
Comment thread
gitar-bot[bot] marked this conversation as resolved.
"falsePositives": 0
}
28 changes: 28 additions & 0 deletions its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S8714.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/HttpURITest.java": [
107
],
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/SyntaxTest.java": [
72,
126
],
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/pathmap/ServletPathSpecTest.java": [
37
],
"org.eclipse.jetty:jetty-project:jetty-io/src/test/java/org/eclipse/jetty/io/ByteArrayEndPointTest.java": [
90,
206,
297
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/MultiPartFormInputStreamTest.java": [
945
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/NotAcceptingTest.java": [
134,
251
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/PartialRFC2616Test.java": [
102,
692
]
}
47 changes: 47 additions & 0 deletions its/ruling/src/test/resources/eclipse-jetty/java-S8714.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/HttpURITest.java": [
107
],
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/SyntaxTest.java": [
72,
126
],
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/pathmap/ServletPathSpecTest.java": [
37
],
"org.eclipse.jetty:jetty-project:jetty-io/src/test/java/org/eclipse/jetty/io/ByteArrayEndPointTest.java": [
90,
206,
297
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/MultiPartFormInputStreamTest.java": [
945
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/NotAcceptingTest.java": [
134,
251
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/PartialRFC2616Test.java": [
102,
692
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java": [
1255,
1263
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/StopTest.java": [
497
],
"org.eclipse.jetty:jetty-project:jetty-util/src/test/java/org/eclipse/jetty/util/BlockingArrayQueueTest.java": [
192
],
"org.eclipse.jetty:jetty-project:jetty-util/src/test/java/org/eclipse/jetty/util/SharedBlockingCallbackTest.java": [
116,
161,
235
],
"org.eclipse.jetty:jetty-project:jetty-util/src/test/java/org/eclipse/jetty/util/thread/AbstractThreadPoolTest.java": [
59,
81
]
}
Loading
Loading