[review] Use AWS OIDC #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build-and-push workflow to leverage AWS OIDC for authentication instead of static credentials.
- Adds job-level permissions for
id-tokenandcontents - Replaces manual Docker login with
configure-aws-credentialsandamazon-ecr-loginactions - Applies the same OIDC-based login in both build jobs
Comments suppressed due to low confidence (2)
.github/workflows/build_and_push.yml:55
- [nitpick] Consider extracting the hard-coded AWS region into a workflow input or environment variable to make it configurable and avoid magic strings.
aws-region: us-east-1
.github/workflows/build_and_push.yml:53
- [nitpick] The credential configuration and ECR login steps are duplicated across jobs; consider refactoring them into a reusable workflow or composite action to reduce repetition.
uses: aws-actions/configure-aws-credentials@b47578312673ae6fa5b5096b330d9fbac3d116df # v4.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.