Skip to content

Messages appear only in proper chatrooms #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Messages appear only in proper chatrooms #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/assets/javascripts/channels/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
App.messages = App.cable.subscriptions.create('MessagesChannel', {
$(document).ready(function() {
chatroomId = $('input#message_chatroom_id').val();
App.messages = App.cable.subscriptions.create({channel: 'MessagesChannel', chatroom_id: chatroomId}, {
received: function(data) {
$("#messages").removeClass('hidden')
$("#messages").removeClass('hidden');
return $('#messages').append(this.renderMessage(data));
},
chatroom_id: function(data) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need this chatroom_id function?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this code a long time ago but I believe it's needed to identify the chatroom.

return data.chatroom_id
},
renderMessage: function(data) {
return "<p> <b>" + data.user + ": </b>" + data.message + "</p>";
}
});
});
})
2 changes: 1 addition & 1 deletion app/channels/messages_channel.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class MessagesChannel < ApplicationCable::Channel
def subscribed
stream_from 'messages'
stream_from "messages_#{params['chatroom_id']}_channel"
end
end
2 changes: 1 addition & 1 deletion app/controllers/messages_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ def create
message = Message.new(message_params)
message.user = current_user
if message.save
ActionCable.server.broadcast 'messages',
ActionCable.server.broadcast "messages_#{message.chatroom_id}_channel",
message: message.content,
user: message.user.username
head :ok
Expand Down