Make it build on node v12.2.0 #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghaiklor
suggested changes
May 30, 2019
ghaiklor
left a comment
ghaiklor
left a comment
There was a problem hiding this comment.
Overall, it is ok, but a lot of code that is not cross-platform in terms of V8.
You must use Nan to cover differences in API between different versions of V8.
| void init(Local<Object> exports) { | ||
| v8::Isolate* isolate = v8::Isolate::GetCurrent(); | ||
| v8::Local<v8::Context> context = isolate->GetCurrentContext(); | ||
| v8::HandleScope handle_scope(isolate); |
There was a problem hiding this comment.
Nan has a helper for these purposes Nan::GetCurrentContext
| Nan::New<FunctionTemplate>(verify)->GetFunction()); | ||
| { | ||
| v8::Local<v8::Function> method; | ||
| Nan::New<FunctionTemplate>(verify)->GetFunction(context).ToLocal<v8::Function>(&method); |
There was a problem hiding this comment.
ToLocaldoes not check if monad is empty or not. Better to useToLocalChecked()- It is a little bit stinky, to use lexical scopes for each set.
| std::string cert_path = *String::Utf8Value(info[0]->ToString()); | ||
| std::string ca_bundlestr = *String::Utf8Value(info[1]->ToString()); | ||
| std::string cert_path = *String::Utf8Value(isolate, info[0]->ToString(isolate)); | ||
| std::string ca_bundlestr = *String::Utf8Value(isolate, info[1]->ToString(isolate)); |
There was a problem hiding this comment.
You can get V8 Isolate by Nan::GetCurrentContext()->GetIsolate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.