chore(cluster stacks): Update Cluster Stacks Addons and Kubernetes to…#230
Conversation
… 1.32.5 Signed-off-by: Jan Schoone <jan.schoone@uhurutec.com>
| name: openstack | ||
| cloudName: openstack | ||
| name: ubuntu-capi-image-v1.32.5 | ||
| openstack_loadbalancer_apiserver: false |
There was a problem hiding this comment.
This changes the default to not have a LB in front of the kubernetes-apiserver. Why?
(Since I switched all my defaults to octavia-ovn, I have started to consider LBs as cheap and reliable resource ...)
There was a problem hiding this comment.
I am still deeply confused to see these tarballs in the git repo.
- Are they even used in any way?
There was a problem hiding this comment.
Basically they must not be in the git repo but in the cluster stack release because CSO can not download them.
So we can add them to gitignore, but then csctl won't work ootb, the helm dependencies must be build before.
I think it would be a good idea to consider SovereignCloudStack/cluster-stack-operator#277
Signed-off-by: Kurt Garloff <kurt@garloff.de>
|
Trying to support both old-style cloud-conf and new-style clouds-yaml config, it would be good for tooling to recognize cluster-classes doing one or the other. |
| @@ -1,10 +1,15 @@ | |||
| apiVersion: v2 | |||
| type: application | |||
| dependencies: | |||
There was a problem hiding this comment.
This duplicates the dependencies: section rather than just moving it so yamllint rightly complains.
| name: cilium | ||
| repository: https://helm.cilium.io/ | ||
| version: 1.17.4 | ||
| version: 1.17.4 No newline at end of file |
There was a problem hiding this comment.
yamllint wants a newline at the end of the file.
Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff
left a comment
There was a problem hiding this comment.
Looks good.
I suggest we do one more final update to scs, pulling all minor versions to the latest, but that's a second step.
… 1.32.5
What this PR does / why we need it:
New versions.
YAML files were ordered by the generate script.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: