Feat: created an helper class that creates a directory in home #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javaspeak
requested changes
Jul 11, 2023
Collaborator
javaspeak
left a comment
javaspeak
left a comment
There was a problem hiding this comment.
There should be a class called:
DirectoryHelperImpl and an interface called DirectoryHelper
You should not be asking the user for the repo name. All the DirectoryHelperImpl should be doing is creating a directory if it does not exist and deleting it and recreating it again if it does exist.
Remember the next task was going to be reading repo details from application.yml file. Therefore you do not need to get the location from the user.
Collaborator
Author
|
Okay i will work on it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.