Grid cell average bug fixes #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this for a bunch of resolutions and grids, they all looks good
|
|
|
|
|
|
Okay something weird happens with Gaussian latitudes at very high resolution but that's irrelevant for now I guess
|
|
Similar with HEALPix grids
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #644 and therefore provides a temporary bypass of #648 by fixing bugs in
RingGrids.grid_cell_average!. Eventually we want to do solve #648 via JuliaGeo/GeometryOps.jl#246 i.e. by calculating area intersections but for now let's just do it the hacky way.This seems to work
and added some tests too