Skip to content

Fix missing channels in OpenEphys XML#347

Merged
alejoe91 merged 4 commits into
SpikeInterface:mainfrom
catalystneuro:fix-read-openephys-for-xml-missing-channels
Oct 27, 2025
Merged

Fix missing channels in OpenEphys XML#347
alejoe91 merged 4 commits into
SpikeInterface:mainfrom
catalystneuro:fix-read-openephys-for-xml-missing-channels

Conversation

@weiglszonja

@weiglszonja weiglszonja commented May 13, 2025

Copy link
Copy Markdown
Contributor

This PR introduces a standalone script (fix_openephys_xml_missing_channels.py) that:

  • Issues a warning when missing channels are detected in the XML (based on the CHANNELS tag)
  • Fills in missing channels in the CHANNELS, ELECTRODE_XPOS, and ELECTRODE_YPOS tags using inferred values
  • Optionally overwrites the original XML or saves a corrected copy (.fixed.xml).

See example for dataset in catalystneuro/schneider-lab-to-nwb#33

@weiglszonja weiglszonja marked this pull request as draft May 13, 2025 16:06
@weiglszonja weiglszonja marked this pull request as ready for review May 14, 2025 13:25
@weiglszonja

Copy link
Copy Markdown
Contributor Author

@h-mayorquin @alejoe91 let me know what you think

@samuelgarcia

Copy link
Copy Markdown
Member

Hi Szonja.
Ok for me.
Would it be possible to add a bit more context doc in the docstring of the function to explain the kind of bugs expected and maybe which version could be affected ?

@weiglszonja

Copy link
Copy Markdown
Contributor Author

Hi Szonja. Ok for me. Would it be possible to add a bit more context doc in the docstring of the function to explain the kind of bugs expected and maybe which version could be affected ?

Thanks, I agree. I'll add this.

@alejoe91 alejoe91 merged commit 563f5b5 into SpikeInterface:main Oct 27, 2025
2 checks passed
@h-mayorquin h-mayorquin deleted the fix-read-openephys-for-xml-missing-channels branch October 27, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants