Handle int32 conversion on TraceView slider for long recordings#253
Open
JoeZiminski wants to merge 1 commit intoSpikeInterface:mainfrom
Open
Handle int32 conversion on TraceView slider for long recordings#253JoeZiminski wants to merge 1 commit intoSpikeInterface:mainfrom
int32 conversion on TraceView slider for long recordings#253JoeZiminski wants to merge 1 commit intoSpikeInterface:mainfrom
Conversation
JoeZiminski
force-pushed
the
fix_qt_int32_slider
branch
from
af28e28 to
9c6c868
Compare
JoeZiminski
changed the title
JoeZiminski
changed the title
int32 conversion on TraceView slider for long recordings
JoeZiminski
changed the title
int32 conversion on TraceView slider for long recordingsint32 conversion on TraceView slider for long recordings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #251 by scaling the value of the slider so that it will always fit in
int32, which Qt uses on the C++ side. This implementation is working, just to get things working for our use case, but not clean. Happy to improve it of course, would be good to hear the best way to structure this. For example, this could be integrated directly intoTimeSeekeror else just abstracted to a few convenience functions.