Rename CurationModel to Curation#4421
Open
alejoe91 wants to merge 10 commits intoSpikeInterface:mainfrom
Open
Conversation
chrishalcrow
reviewed
Mar 4, 2026
| return full_spike_indices | ||
|
|
||
|
|
||
| class CurationModel(BaseModel): |
Member
There was a problem hiding this comment.
Should we deprecate? We use CurationModel in our lab's spike sorting pipeline (though I'd guess I'm a power user).
Would also make it easier on the e.g. si-gui side
Member
Author
There was a problem hiding this comment.
Yes we definitely should! I'll add a fake function with a deprecation warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the new
SequentialCuration, @samuelgarcia suggested there is no need for theModelin the name