Skip to content

Conversation

anders-lassen
Copy link

#1350

Description

This PR adds an extra disabled check to the onPointerUp and onPointerMove methods in the Drag component of SplideJs. This change is necessary to improve the flexibility of combining SplideJs with other features, such as pinch zoom.

Changes

  • Added an extra disabled check to the onPointerUp method to prevent the event from being registered when the component is disabled.
  • Added an extra disabled check to the onPointerMove method to prevent the slider from moving when the component is disabled.

@enix79
Copy link

enix79 commented Aug 11, 2025

I agree. The issue here, is that drag= falseworks, but in the onTouchMove and onTouchUp the logic is execuded even when Drag is disabled. There, event is getting prevented so we have no chance to react to it from the outside and implement something like pinch/zoom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants