-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add info to the speak page #365
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
@@ -35,9 +35,14 @@ export default function About() { | |||
<UnorderedList> | |||
<li> | |||
Send us your slides 24 hours in advance, so we can check them for | |||
accessibility | |||
accessibility and/or dry run your talk with us the week before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we're going with dry runs as non-optional:
<li>
Present a dry run of your talk the week before, so we can check it
for accessibility issues and make sure it runs the expected duration.
</li>
Optional: Provide us with an avatar, name, description, and URL | ||
(social, website, etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been treating the first few as required for social media & Eventbrite, I think?
Optional: Provide us with an avatar, name, description, and URL | |
(social, website, etc.) | |
Provide us with a name, talk description, talk title, and optionally: avatar, personal URL, and any social media profiles to share |
PR Checklist
status: accepting prs
Overview