-
Notifications
You must be signed in to change notification settings - Fork 99
chore(colors): update color palettes #2015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CGuindon, @leileitun3 I've popped in a few questions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to reviewers: This file is where the vast majority of changes have happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color values should be (I think some of these are the ones Lei Lei tweaked recently):
- Light mode
blue400: hsl(226, 67%, 95%) - Light mode
green200: hsv(82, 30%, 95%) - HC Light mode
green300: hsv(82, 80%, 63%) - HC Light mode
green400: hsv(82, 93%, 38%) - Dark mode
red500: hsv(0, 20%, 99%) - Light mode
yellow200: hsv(48, 36%, 96%); - Light mode
pink
100: hsv(293, 6%, 99%);
200: hsv(293, 25%, 95%);
300: hsv(293, 45%, 95%);
400: hsv(293, 68%, 91%);
500: hsv(293, 80%, 70%);
600: hsv(293, 90%, 45%); - HC Light mode
pink300: hsv(293, 68%, 91%); - HC Dark mode
pink400: hsv(293, 30%, 80%);
|
@CGuindon thank you for the detailed suggestions. You saved me a lot of time (your bolding helped a lot!) 🫶 I've made those changes in 6a9f965. I've also:
I might be misunderstanding. You're suggesting that the dark and dark HC orange palettes are swapped? To me it looks correct. Can you clarify @CGuindon?
|
@dancormier The oranges looked swapped in the preview but I don't think I saw anything that off in the code file you sent me... Would that preview need to be regenerated? |
|
@dancormier I don't mind having the buttons remain blue in the Teams template/default but ideally SE sites (without custom) use the new black buttons down the line. |
Since blue is no longer being used as a theme color, I'd suggest replacing it with black. I haven't tested it, but I think we could get away with mapping black color stops 1-to-1 with theme secondary stops and then have
In this orientation, we'd default to using |
|
I've updated this PR to have I think it looks alright and allows it to be overridden by a custom theme. @CGuindon please give it a look and let me know what you think. Thanks! |
|
@dancormier I think that makes sense to me. Looping in @andrewmeacham to see if he has any extra insights we're not considering for theming. How do I test the theming in this PR? |
|
Approved in case you need colors to merge sooner than later since it's blocking other tickets — I think documentation still needs to be updated (add pink to usage). Maybe we can spin up a separate PR/ticket for that if needed. |
Click the button far right end of the navbar (after the search input). There, we the have a toggle within the popover to apply a custom theme. This is a custom theme we've applied in the docs using the same functions one would as a consumer of Stacks.
Thank you! Is there guidance written down anywhere for pink? I looked in the Figma but didn't find it. Happy to add a row for guidance on that. If there are lots of docs changes missing, I'll create a follow up ticket. |







SPARK-49
Deploy preview
This PR updates Stacks to use the new SHINE color palettes.
TODO
(verify) Update or remove translucent color sets (these are mostly used for focus rings)cc @leileitun3