Skip to content

fix(deps): bump undici to 6.29.1 (GHSA-rfgv-xxqx-mfg5) - #450

Merged
flaxel merged 2 commits into
mainfrom
fix-undici-ghsa-rfgv-xxqx-mfg5
Oct 30, 2026
Merged

flaxel merged 2 commits into
mainfrom
fix-undici-ghsa-rfgv-xxqx-mfg5

Conversation

@flaxel

@flaxel flaxel commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix

Description

Fix high-severity Dependabot alert #100 (GHSA-rfgv-xxqx-mfg5). The exact undici pin (6.27.0) is removed from the overrides. All consumers request ^6.23.0, so the lockfile now resolves undici 6.29.1, and Dependabot can bump it again later. dist is rebuilt.

How to review

Check the removed override and the lockfile, confirm pnpm why undici shows only 6.29.1, verify CI is green, and review the dist diff for the undici update.

Checklist

  • Make sure all tests pass

@flaxel flaxel added the ktlo Pull requests that keep the lights on, such as incidents, maintenance, and upkeep label Oct 30, 2026
@flaxel
flaxel marked this pull request as ready for review October 30, 2026 07:03
@flaxel
flaxel requested a review from a team as a code owner October 30, 2026 07:03
@flaxel
flaxel requested review from axdotl and timdittler October 30, 2026 07:03
@flaxel
flaxel enabled auto-merge (squash) October 30, 2026 07:03
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

✅ Low risk — This routine dependency configuration change does not alter application behavior.
This change aims to address the undici security alert and let Dependabot update undici without an exact version pin.

Walkthrough

The undici override that pinned version 6.27.0 was removed from pnpm-workspace.yaml.

Priority: Low

Merge Risk: Minimal · up to eec62

The dependency change is ready to merge after normal checks; the lockfile and bundled code use undici 6.29.1.

Architecture risk: Low · up to 79d16

The change affects 1 system.

Changed systems: pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pnpm-workspace.yaml: The undici override changes from version 6.27.0 to 6.29.1, and its associated Dependabot reference is updated.
Pre-merge checks: Passed 1
Check name Status Explanation
Title check Passed The title uses the conventional commit format and accurately describes the undici dependency update. It does not include a ticket key, which is permitted for untracked work.
Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

All consumers request undici ^6.23.0, so the lockfile resolves 6.29.1
without a pin. Removing the exact pin lets Dependabot bump undici again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@timdittler

Copy link
Copy Markdown
Contributor

@flaxel I prefer deleting the override. This was only a temporary measure.

@flaxel
flaxel merged commit 2df9fa4 into main Oct 30, 2026
10 checks passed
@flaxel
flaxel deleted the fix-undici-ghsa-rfgv-xxqx-mfg5 branch October 30, 2026 08:33
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ktlo Pull requests that keep the lights on, such as incidents, maintenance, and upkeep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants