Repository navigation
feat: Add scroll containment for embedded plugins - #390
Closed
maximizeIT wants to merge 1 commit into
Closed
maximizeIT wants to merge 1 commit into
maximizeIT wants to merge 1 commit into
Conversation
Element.scrollIntoView also scrolls the page around the plugin iframe. With a footer configured that page scrolls, so jumps inside a plugin (e.g. letter anchors in the glossary) moved the host page under its header. scrollIntoViewContained scrolls only inside the plugin document; installScrollContainment makes the native method do the same. Co-authored-by: OpenCode <noreply@opencode.ai> Co-authored-by: GitHub Copilot <copilot@noreply.github.com>
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
scrollIntoViewContained(element, options)andinstallScrollContainment().Element.scrollIntoViewalso scrolls the page around the plugin's iframe. When the Staffbase app shows a footer, that page scrolls too, so jumps inside a plugin (e.g. the glossary's letter index) move the page under the app header.scrollIntoViewContained: same arguments asscrollIntoView, scrolls only inside the plugin document.installScrollContainment: makes the native method do the same, only inside a frame. Returns a restore function.How Has This Been Tested?
scrollY0, plugin scroll matches native.Quick check in a plugin frame's console, after loading the UMD build:
Types of changes
Checklist:
Test plan:
Open a plugin on a branch with the intranet footer enabled, call the snippet above, and confirm the Staffbase page does not scroll.
Created with OpenCode; AI wrote most of this change.