Skip to content

Conversation

@jzunigax2
Copy link

Previously on each api call http.DefaultClient was being used. This PR introduces a centralized http client injected through config, which has some settings like timeouts setup

@jzunigax2 jzunigax2 closed this Nov 21, 2025
@lullius
Copy link

lullius commented Nov 22, 2025

@jzunigax2
I recommend checking #5 and the client branch. It has a centralized client and is a complete rewrite with a lot of cleanup. We didn't merge it into master because of breaking changes.
I see you're working on a fork over at https://github.com/internxt/rclone-adapter. Since it's early and you might not have other projects depending on it yet, consider forking the client branch instead. It could prevent duplicated work.

@jzunigax2
Copy link
Author

@jzunigax2 I recommend checking #5 and the client branch. It has a centralized client and is a complete rewrite with a lot of cleanup. We didn't merge it into master because of breaking changes. I see you're working on a fork over at https://github.com/internxt/rclone-adapter. Since it's early and you might not have other projects depending on it yet, consider forking the client branch instead. It could prevent duplicated work.

Thanks @lullius ! I'll be sure to check it out

@lullius
Copy link

lullius commented Nov 22, 2025

@jzunigax2
I'm guessing you're making an rclone backend based on the name of your repository. If I remember correctly
StarHack/rclone#4 was written to make use of the client branch in this repo. I think it should pass all of rclone's tests in the version of rclone it was forked from. I'm not sure it will pass on the current version of rclone as some things have changed since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants