Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service labels #632

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Conversation

dd-willgan
Copy link
Contributor

@dd-willgan dd-willgan commented Mar 18, 2025

Description

Currently adding K8s service annotations are supported but not labels. Support service labels through the following changes:

  • Update CRD definitions in config/crd/bases/ and deploy/
  • Update Helm chart templates and values for helm-charts/charts/kube-starrocks/ and helm-charts/charts/warehouse/
  • Update pkg/apis/starrocks/v1/
  • Update pkg/common/resource_utils/service and pkg/k8sutils/templates/service/spec to handle labels
    • Still support default labels generated by operator
  • Update subcontrollers so that external service has labels but internal labels don't

Related Issue(s)

#625

Checklist

For operator, please complete the following checklist:

  • run make generate to generate the code.
  • run golangci-lint run to check the code style.
  • run make test to run UT.
  • run make manifests to update the yaml files of CRD.

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2025

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Will Gan <[email protected]>
@dd-willgan dd-willgan requested a review from yandongxiao March 18, 2025 16:37
@yandongxiao yandongxiao merged commit e5ab9e9 into StarRocks:main Mar 19, 2025
3 checks passed
@yandongxiao
Copy link
Collaborator

@dd-willgan Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants