✨ feat(audit-loader): add AuditLoader installation support #633
Conversation
|
|
Introduce a new feature to install and configure the AuditLoader plugin, enhancing auditing capabilities. Signed-off-by: buu.nguyen <[email protected]>
buu-nguyen
force-pushed
the
feat-install-audit-loader
branch
from
4f73b7a to
8cfacc2
Compare
|
Hi @yandongxiao, could you please take a look at this PR when you have time? Thanks in advance! |
| PARTITION BY date_trunc('day', `timestamp`) | ||
| DISTRIBUTED BY HASH (`queryId`); | ||
|
|
||
| INSTALL PLUGIN FROM "/opt/starrocks-plugins/auditloader.zip"; |
There was a problem hiding this comment.
According to the introduction at https://docs.starrocks.io/docs/administration/management/audit_loader/, INSTALL PLUGIN FROM can specify a URL in HTTP format. We do not need an init container to do additional download work.
There was a problem hiding this comment.
If using HTTP to install plugins, we just need to ensure that the above SQL command can be executed after the StarRock cluster starts.
You may consider another implementation method. Currently, Operator supports Command and Args parameters. Correspondingly, in Helm Chart, we expose an entrypoint field.
| @@ -0,0 +1,64 @@ | |||
| {{- if and .Values.installAuditLoader.enabled .Values.installAuditLoader.isInstall .Release.IsInstall }} | |||
| apiVersion: batch/v1 | |||
| kind: Job | |||
There was a problem hiding this comment.
Although there is a Job in the Helm Chart to initialize the SQL password, I do not think it is reasonable to do this work through a Job. Because Jobs and StarRocks Pods are executed in parallel, it is very likely that when the Pod of the Job starts execution, StarRocks has not successfully started yet. We always need to retry to complete this task.
Description
Introduce a new feature to install and configure the AuditLoader plugin, enhancing auditing capabilities.
The installation process is inspired by the official documentation on the website: https://docs.starrocks.io/docs/administration/management/audit_loader/
Checklist
For helm chart, please complete the following checklist:
file of starrocks chart.
scriptsdirectory, runbash create-parent-chart-values.shto update the values.yaml file of the parentchart( kube-starrocks chart).