Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] limit the state size of FlatJson to avoid excessive memory consumption #57139

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Mar 21, 2025

Why I'm doing:

What I'm doing:

For complicate JSON structure, the JsonFlattener can consume excessive memory.

To solve this problem, here we add a hard limit on the state: json_flat_column_max * 10.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Sorry, something went wrong.

@murphyatwork murphyatwork requested a review from a team as a code owner March 21, 2025 02:28
@murphyatwork
Copy link
Contributor Author

@Mergifyio rebase

Signed-off-by: Murphy <mofei@starrocks.com>
Copy link
Contributor

mergify bot commented Mar 21, 2025

rebase

✅ Branch has been successfully rebased

@murphyatwork murphyatwork force-pushed the murphy_fix_flat_json_too_many_keys branch from c521306 to 8ed00d8 Compare March 21, 2025 13:44
@murphyatwork
Copy link
Contributor Author

ignore merge 3.5

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/util/json_flattener.cpp 4 4 100.00% []

@murphyatwork murphyatwork marked this pull request as draft March 24, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants