Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Delete shards meta from starmgr after recycling partition for cloud-native cluster (backport #56691) #57282

Merged
merged 1 commit into from
Apr 3, 2025
Merged

[Enhancement] Delete shards meta from starmgr after recycling partition for cloud-native cluster (backport #56691) #57282

merged 1 commit into from
Apr 3, 2025
+95 −0

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 25, 2025 •
edited by wanpengfei-git
Loading

Why I'm doing:

Currently, the RecycleBin is responsible for removing partition directories from remote storage, but it relies on StarMgrMetaSyncer to clean up shard metadata from StarMgr. However, since StarMgrMetaSyncer was not designed to handle heavy cleanup tasks, it would be more efficient to remove the metadata immediately after the RecycleBin completes its work.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Sorry, something went wrong.

@mergify mergify bot mentioned this pull request Mar 25, 2025
Merged
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 25, 2025 13:42
@wxl24life
Copy link
Contributor

@kevincai can this backport be merged? no conflicts here, maybe need do some rebase work

@kevincai
Copy link
Contributor

kevincai commented Apr 3, 2025

@kevincai can this backport be merged? no conflicts here, maybe need do some rebase work

still fight for CI checks

@kevincai
Copy link
Contributor

kevincai commented Apr 3, 2025

@Mergifyio rebase

@wxl24life @kevincai
[Enhancement] Delete shards meta from starmgr after recycling partiti…
b7cde13 
…on for cloud-native cluster (#56691)

Signed-off-by: drake_wang <wxl250059@alibaba-inc.com>
(cherry picked from commit 387dcbb)
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Apr 3, 2025

rebase

✅ Branch has been successfully rebased

@kevincai kevincai force-pushed the mergify/bp/branch-3.4/pr-56691 branch from 906cb4e to b7cde13 Compare April 3, 2025 02:02
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@kevincai kevincai self-assigned this Apr 3, 2025
@wanpengfei-git wanpengfei-git merged commit 63b6359 into branch-3.4 Apr 3, 2025
32 of 34 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.4/pr-56691 branch April 3, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai

Assignees

@kevincai kevincai

Labels
automerge version:3.4.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wxl24life @kevincai @wanpengfei-git