Skip to content

[Enhancement] enable shared scan when doing insert #57360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dirtysalt
Copy link
Contributor

@dirtysalt dirtysalt commented Mar 27, 2025

Why I'm doing:

#12070

In this pr, for insert SQL stmt, it forces to use "scan rangers per driver seq"

                if (targetTable instanceof OlapTable) {
                    sinkFragment.setHasOlapTableSink();
                    sinkFragment.setForceAssignScanRangesPerDriverSeq();

And in backend code, if set "scan ranges per drive seq", then backend can not use shared scan any more.

But for external table, there is no sense of "scan ranges per drive seq" at all. So for scan node which has property of "always shared scan", we still use shared scan.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@dirtysalt dirtysalt requested a review from a team as a code owner March 27, 2025 13:00
@dirtysalt dirtysalt closed this Mar 28, 2025
@dirtysalt
Copy link
Contributor Author

I don't know why, but when executing following command

create table t1 as select * from files("path"="hdfs://emr-header-1.cluster-49091:9000/starrocks_test_data/system_data/test_files//all_right.csv,hdfs://emr-header-1.cluster-49091:9000/starrocks_test_data/system_data/test_fil
es//test_push_down_int.csv", "format"="csv","csv.column_separator" = "|" ,"auto_detect_sample_files"="1")

the table t1 is empty. I think it's related to sink operator's requirement.

I'm gonna to put this feature off a bit, since there is no impact right now.

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/scan_node.cpp 1 1 100.00% []

@dirtysalt dirtysalt deleted the fix-isnert-from-exttable-shared-scan branch March 29, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant