Open
Conversation
…ализация обновления баланса по начислениям
…ного пользователя) экспериментирую с plantuml - добавил диаграмму таблиц
логгер для бизнес-операций берется из контекста
alekstet
reviewed
Apr 27, 2024
| if err != nil { | ||
| return nil, fmt.Errorf("%w: %v", domain.ErrServerInternal, err.Error()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Ты ниже так много раз вызываешь resp.StatusCode()
Может лучше уж переменную сделать
alekstet
reviewed
Apr 27, 2024
|
|
||
| if orderData == nil { | ||
| logger.Errorw("storage.UpdateBalanceByOrder", "err", "orderData is nil") | ||
| return fmt.Errorf("%w: orderData is nil", domain.ErrServerInternal) |
There was a problem hiding this comment.
Это же не ошибка сервера что данные пустые
Owner
Author
There was a problem hiding this comment.
Идея была такая - что если данные нулевые - то это ошибка в реализации/кофигурации.
Добавил ErrServerImplementationError для таких случаев.
alekstet
reviewed
Apr 27, 2024
| return err | ||
| } | ||
|
|
||
| rows, err := st.pPool.Query(ctx, |
There was a problem hiding this comment.
Не совсем понимаю ты делаешь Query
Это же просто Exec
Owner
Author
There was a problem hiding this comment.
Убрал метод как неиспользуемый.
alekstet
approved these changes
Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.