Skip to content

chore(build): upgrade Gradle wrapper and Docker build images to 9.5.1#6501

Open
Ludy87 wants to merge 6 commits into
mainfrom
bump_gradle_9_5_1_20260531
Open

chore(build): upgrade Gradle wrapper and Docker build images to 9.5.1#6501
Ludy87 wants to merge 6 commits into
mainfrom
bump_gradle_9_5_1_20260531

Conversation

@Ludy87
Copy link
Copy Markdown
Collaborator

@Ludy87 Ludy87 commented May 31, 2026

Description of Changes

This PR upgrades the Gradle toolchain used across local development and Docker-based builds from Gradle 9.3.1 to Gradle 9.5.1.

What was changed

  • Updated gradle-wrapper.properties to use Gradle 9.5.1.
  • Refreshed gradle-wrapper.jar to the version generated by the updated wrapper.
  • Updated Docker build images in:
    • docker/embedded/Dockerfile
    • docker/embedded/Dockerfile.fat
    • docker/embedded/Dockerfile.ultra-lite
  • Added image digest pinning for Docker build stages where applicable.
  • Updated generated wrapper scripts:
    • gradlew
    • gradlew.bat
  • Included new wrapper configuration options:
    • retries=0
    • retryBackOffMs=500

Why the change was made

  • Align local and containerized build environments on the latest Gradle release.
  • Benefit from Gradle wrapper improvements, fixes, and compatibility updates.
  • Improve build reproducibility by using updated and pinned Docker image references.
  • Keep generated wrapper artifacts synchronized with the Gradle version in use.

Checklist

General

Documentation

Translations (if applicable)

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have run task check to verify linters, typechecks, and tests pass
  • I have tested my changes locally. Refer to the Testing Guide for more details.

Ludy87 added 2 commits May 31, 2026 13:26
Bump the gradle-version input from 9.3.1 to 9.5.1 across multiple GitHub Actions workflow files under .github/workflows to use the newer Gradle release in CI. This ensures consistency across workflows and picks up improvements/bugfixes in the newer Gradle version.
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines ignoring generated files. label May 31, 2026
@stirlingbot stirlingbot Bot added Docker Pull requests that update Docker code API API-related issues or pull requests Github chore Routine tasks or maintenance that don't modify src or test files Gradle Pull requests that update Gradle code labels May 31, 2026
Comment thread gradlew.bat
echo location of your Java installation. 1>&2

goto fail
"%COMSPEC%" /c exit 1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reporting missing Java, %COMSPEC% /c exit 1 does not stop batch flow here; execution falls through to later labels, causing contradictory error path handling.

Details

✨ AI Reasoning
​The script is trying to stop when Java is missing. After printing the 'JAVA_HOME is not set and no java command' error, it now runs a command that returns code 1 but does not redirect flow. In batch execution this falls through into the next labeled section, so the script continues as if it should also validate JAVA_HOME, which contradicts the earlier branch condition.

🔧 How do I fix it?
Trace execution paths carefully. Ensure precondition checks happen before using values, validate ranges before checking impossible conditions, and don't check for states that the code has already ruled out.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AikidoSec The update via ./gradlew wrapper --gradle-version=9.5.1 && ./gradlew wrapper automatically updated gradlew.bat.

Comment thread gradlew.bat
echo location of your Java installation. 1>&2

goto fail
"%COMSPEC%" /c exit 1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On invalid JAVA_HOME, %COMSPEC% /c exit 1 does not branch out, so control can fall through to :execute and attempt running %JAVA_EXE% anyway.

Details

✨ AI Reasoning
​This branch intends to terminate when JAVA_HOME points to an invalid directory. The new command sets a nonzero code but does not change execution path, so the script continues to the execution section and still attempts to run Java. That makes the failure branch assumptions internally inconsistent.

🔧 How do I fix it?
Trace execution paths carefully. Ensure precondition checks happen before using values, validate ranges before checking impossible conditions, and don't check for states that the code has already ruled out.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AikidoSec The update via ./gradlew wrapper --gradle-version=9.5.1 && ./gradlew wrapper automatically updated gradlew.bat.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines ignoring generated files. and removed size:M This PR changes 30-99 lines ignoring generated files. labels May 31, 2026
Detect whether jlink supports the newer zip-N compress syntax and choose a compatible --compress value instead of hardcoding zip-6. The taskfile (.taskfiles/desktop.yml) now sets JLINK_COMPRESS based on jlink --help output and the mac build script (frontend/editor/scripts/build-universal-mac-jre.sh) sets a local compress variable the same way, then passes that into jlink. This makes the JRE packaging step robust across different jlink versions.
@stirlingbot stirlingbot Bot added the Front End Issues or pull requests related to front-end development label May 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 31, 2026

📦 Tauri Desktop Builds Ready!

The desktop applications have been built and are ready for testing.

Download Artifacts:

🐧 Linux x64: Download Stirling-PDF-linux-x86_64 (.deb, .rpm, .AppImage) - 754.6 MB
🍎 macOS Universal: Download Stirling-PDF-macos-universal (.dmg) - 268.2 MB
🪟 Windows x64: Download Stirling-PDF-windows-x86_64 (.exe, .msi) - 224.0 MB


Built from commit 6231b1d
Artifacts expire in 7 days

@stirlingbot
Copy link
Copy Markdown
Contributor

stirlingbot Bot commented Jun 2, 2026

✅ Backend License Check Passed

All backend dependencies have valid and allowed licenses.

The backend license report has been updated successfully.

@stirlingbot
Copy link
Copy Markdown
Contributor

stirlingbot Bot commented Jun 2, 2026

✅ Frontend License Check Passed

All frontend licenses have been validated and no compatibility warnings were detected.

The frontend license report has been updated successfully.

@stirlingbot
Copy link
Copy Markdown
Contributor

stirlingbot Bot commented Jun 2, 2026

🚀 V2 Auto-Deployment Complete!

Your V2 PR with embedded architecture has been deployed!

🔗 Direct Test URL (non-SSL) http://54.175.155.236:6501

🔐 Secure HTTPS URL: https://6501.ssl.stirlingpdf.cloud

This deployment will be automatically cleaned up when the PR is closed.

🔄 Auto-deployed for approved V2 contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API API-related issues or pull requests chore Routine tasks or maintenance that don't modify src or test files Docker Pull requests that update Docker code Front End Issues or pull requests related to front-end development Github Gradle Pull requests that update Gradle code size:L This PR changes 100-499 lines ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant