chore(build): upgrade Gradle wrapper and Docker build images to 9.5.1#6501
chore(build): upgrade Gradle wrapper and Docker build images to 9.5.1#6501Ludy87 wants to merge 6 commits into
Conversation
Bump the gradle-version input from 9.3.1 to 9.5.1 across multiple GitHub Actions workflow files under .github/workflows to use the newer Gradle release in CI. This ensures consistency across workflows and picks up improvements/bugfixes in the newer Gradle version.
| echo location of your Java installation. 1>&2 | ||
|
|
||
| goto fail | ||
| "%COMSPEC%" /c exit 1 |
There was a problem hiding this comment.
After reporting missing Java, %COMSPEC% /c exit 1 does not stop batch flow here; execution falls through to later labels, causing contradictory error path handling.
Details
✨ AI Reasoning
The script is trying to stop when Java is missing. After printing the 'JAVA_HOME is not set and no java command' error, it now runs a command that returns code 1 but does not redirect flow. In batch execution this falls through into the next labeled section, so the script continues as if it should also validate JAVA_HOME, which contradicts the earlier branch condition.
🔧 How do I fix it?
Trace execution paths carefully. Ensure precondition checks happen before using values, validate ranges before checking impossible conditions, and don't check for states that the code has already ruled out.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
There was a problem hiding this comment.
@AikidoSec The update via ./gradlew wrapper --gradle-version=9.5.1 && ./gradlew wrapper automatically updated gradlew.bat.
| echo location of your Java installation. 1>&2 | ||
|
|
||
| goto fail | ||
| "%COMSPEC%" /c exit 1 |
There was a problem hiding this comment.
On invalid JAVA_HOME, %COMSPEC% /c exit 1 does not branch out, so control can fall through to :execute and attempt running %JAVA_EXE% anyway.
Details
✨ AI Reasoning
This branch intends to terminate when JAVA_HOME points to an invalid directory. The new command sets a nonzero code but does not change execution path, so the script continues to the execution section and still attempts to run Java. That makes the failure branch assumptions internally inconsistent.
🔧 How do I fix it?
Trace execution paths carefully. Ensure precondition checks happen before using values, validate ranges before checking impossible conditions, and don't check for states that the code has already ruled out.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
There was a problem hiding this comment.
@AikidoSec The update via ./gradlew wrapper --gradle-version=9.5.1 && ./gradlew wrapper automatically updated gradlew.bat.
Detect whether jlink supports the newer zip-N compress syntax and choose a compatible --compress value instead of hardcoding zip-6. The taskfile (.taskfiles/desktop.yml) now sets JLINK_COMPRESS based on jlink --help output and the mac build script (frontend/editor/scripts/build-universal-mac-jre.sh) sets a local compress variable the same way, then passes that into jlink. This makes the JRE packaging step robust across different jlink versions.
📦 Tauri Desktop Builds Ready!The desktop applications have been built and are ready for testing. Download Artifacts:🐧 Linux x64: Download Stirling-PDF-linux-x86_64 (.deb, .rpm, .AppImage) - 754.6 MB Built from commit 6231b1d |
✅ Backend License Check PassedAll backend dependencies have valid and allowed licenses. The backend license report has been updated successfully. |
✅ Frontend License Check PassedAll frontend licenses have been validated and no compatibility warnings were detected. The frontend license report has been updated successfully. |
🚀 V2 Auto-Deployment Complete!Your V2 PR with embedded architecture has been deployed! 🔗 Direct Test URL (non-SSL) http://54.175.155.236:6501 🔐 Secure HTTPS URL: https://6501.ssl.stirlingpdf.cloud This deployment will be automatically cleaned up when the PR is closed. 🔄 Auto-deployed for approved V2 contributors. |
Description of Changes
This PR upgrades the Gradle toolchain used across local development and Docker-based builds from Gradle 9.3.1 to Gradle 9.5.1.
What was changed
gradle-wrapper.propertiesto use Gradle9.5.1.gradle-wrapper.jarto the version generated by the updated wrapper.docker/embedded/Dockerfiledocker/embedded/Dockerfile.fatdocker/embedded/Dockerfile.ultra-litegradlewgradlew.batretries=0retryBackOffMs=500Why the change was made
Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)
task checkto verify linters, typechecks, and tests pass