Skip to content

Fix settings: dark borders, update dropdown z-index, dead accessibility link #6528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frooodle merged 3 commits into from
Jun 4, 2026
+15 −15
Merged

Fix settings: dark borders, update dropdown z-index, dead accessibility link #6528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ccd11d
Fix settings: dark borders, update dropdown z-index, dead accessibili…
Frooodle Jun 3, 2026
f099160
Remove Accessibility footer link test assertion
Frooodle Jun 4, 2026
dfc869e
Merge branch 'main' into bugfix/settings-dark-borders-and-update-drop…
Frooodle Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions frontend/editor/src/core/components/shared/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,10 @@ export default function Footer({
// Default URLs
const defaultTermsUrl = "https://www.stirling.com/terms";
const defaultPrivacyUrl = "https://www.stirling.com/privacy";
const defaultAccessibilityUrl = "https://www.stirling.com/accessibility";

// Use provided URLs or fall back to defaults
const finalTermsUrl = finalTermsAndConditions || defaultTermsUrl;
const finalPrivacyUrl = finalPrivacyPolicy || defaultPrivacyUrl;
const finalAccessibilityUrl =
finalAccessibilityStatement || defaultAccessibilityUrl;

// Helper to check if a value is valid (not null/undefined/empty string)
const isValidLink = (link?: string) => link && link.trim().length > 0;
Expand Down Expand Up @@ -121,14 +118,16 @@ export default function Footer({
>
{t("footer.issues", "GitHub")}
</a>
<a
className="footer-link px-3"
target="_blank"
rel="noopener noreferrer"
href={finalAccessibilityUrl}
>
{t("legal.accessibility", "Accessibility")}
</a>
{isValidLink(finalAccessibilityStatement) && (
<a
className="footer-link px-3"
target="_blank"
rel="noopener noreferrer"
href={finalAccessibilityStatement}
>
{t("legal.accessibility", "Accessibility")}
</a>
)}
{isValidLink(finalCookiePolicy) && (
<a
className="footer-link px-3"
Expand Down
4 changes: 4 additions & 0 deletions frontend/editor/src/core/components/shared/config/configSections/GeneralSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,10 @@ const GeneralSection: React.FC<GeneralSectionProps> = ({
},
]}
maw={360}
comboboxProps={{
withinPortal: true,
zIndex: Z_INDEX_OVER_CONFIG_MODAL,
}}
/>
</Stack>
)}
Expand Down
2 changes: 1 addition & 1 deletion frontend/editor/src/core/styles/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@
/* Always-dark text (for use on light backgrounds like alerts) - does not change in dark mode */
--text-always-dark: #1f2937;
--text-always-dark-muted: #6b7280;
--border-subtle: #2a2f36;
--border-subtle: rgba(255, 255, 255, 0.08);
--border-default: #3a4047;
--border-strong: #4b5563;
--hover-bg: #374151;
Expand Down
3 changes: 0 additions & 3 deletions frontend/editor/src/core/tests/stubbed/main-dashboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,6 @@ test.describe("2. Main Dashboard / Home Page", () => {
await expect(page.getByText("GitHub").first()).toBeVisible({
timeout: 10000,
});
await expect(page.getByText("Accessibility").first()).toBeVisible({
timeout: 10000,
});

const githubLink = page
.locator('a[href*="github.com/Stirling-Tools/Stirling-PDF"]')
Expand Down
Loading