fix(ci): upload Playwright reports from the correct frontend directory#6859
Open
Ludy87 wants to merge 4 commits into
Open
fix(ci): upload Playwright reports from the correct frontend directory#6859Ludy87 wants to merge 4 commits into
Ludy87 wants to merge 4 commits into
Conversation
Update CI workflow artifact upload paths to reflect the new directory structure where playwright-report is now located at frontend/playwright-report/ instead of frontend/editor/playwright-report/.
Ludy87
requested review from
ConnorYoh,
EthanHealy01,
Frooodle,
jbrunton96 and
reecebrowne
as code owners
dosubot
Bot
added
size:XS
Switch Playwright frontend coverage artifact to a stable name so the aggregate workflow can reliably download it. Replaced run-specific name (playwright-frontend-coverage-${{ github.run_id }}) with playwright-frontend-coverage in:
- .github/workflows/e2e-live.yml (upload)
- .github/workflows/coverage-aggregate.yml (download)
Pass producer job results into the coverage-aggregate workflow and use them to conditionally download frontend coverage artifacts. Added two inputs (frontend-validation-result, playwright-e2e-live-result) with default 'skipped', updated build.yml to forward the results, and replaced unconditional downloads (if: always()) with checks that only run the download when the producer job returned 'success'. This avoids failed or unnecessary artifact downloads on backend-only runs.
Contributor
🚀 V2 Auto-Deployment Complete!Your V2 PR with embedded architecture has been deployed! 🔗 Direct Test URL (non-SSL) http://54.175.155.236:6859 🔐 Secure HTTPS URL: https://6859.ssl.stirlingpdf.cloud This deployment will be automatically cleaned up when the PR is closed. 🔄 Auto-deployed for approved V2 contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This change fixes the artifact upload path used by the Playwright E2E workflows after the frontend directory structure was updated.
What was changed
frontend/editor/playwright-report/frontend/playwright-report/build-enterprise.ymle2e-stubbed.ymlnightly.ymlplaywright-nightly-${{ github.run_id }}playwright-report-nightly-${{ github.run_id }}for consistency with the other workflows.
Why the change was made
The workflows attempted to upload artifacts from a directory that no longer exists, causing GitHub Actions to report:
Updating the upload path ensures Playwright reports are successfully collected and available for debugging failed E2E runs.
Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)
task checkto verify linters, typechecks, and tests pass