Skip to content

fix(chat): prevent focus from landing inside hidden FAB panel#6866

Open
Ludy87 wants to merge 1 commit into
mainfrom
fix_chat_20260702
Open

fix(chat): prevent focus from landing inside hidden FAB panel#6866
Ludy87 wants to merge 1 commit into
mainfrom
fix_chat_20260702

Conversation

@Ludy87

@Ludy87 Ludy87 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Description of Changes

  • Changed the chat FAB so the panel content is mounted only while the window is open.
  • Kept the floating window shell animated, but removed the hidden textarea from the DOM when closed.
  • Added ref forwarding to ChatFABButton so focus can be returned to the trigger after closing the panel.
  • Kept the close flow explicit so keyboard focus is moved out before the panel hides.

Why this change was made:

  • The browser was warning that aria-hidden was being applied to a container while its textarea descendant still had focus.
  • That broke accessibility expectations and created noisy console warnings during normal chat close/open interactions.
  • Mounting the chat panel only when open removes the hidden-focused-descendant state entirely.

Checklist

General

Documentation

Translations (if applicable)

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have run task check to verify linters, typechecks, and tests pass
  • I have tested my changes locally. Refer to the Testing Guide for more details.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines ignoring generated files. Bugfix Pull requests that fix bugs labels Jul 2, 2026
@stirlingbot stirlingbot Bot added the Front End Issues or pull requests related to front-end development label Jul 2, 2026
@stirlingbot

stirlingbot Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🚀 V2 Auto-Deployment Complete!

Your V2 PR with embedded architecture has been deployed!

🔗 Direct Test URL (non-SSL) http://54.175.155.236:6866

🔐 Secure HTTPS URL: https://6866.ssl.stirlingpdf.cloud

This deployment will be automatically cleaned up when the PR is closed.

🔄 Auto-deployed for approved V2 contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Pull requests that fix bugs Front End Issues or pull requests related to front-end development size:L This PR changes 100-499 lines ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant