Read the Downloads folder from the machine, not the server - #7964
Draft
Frooodle wants to merge 10 commits into
Draft
Read the Downloads folder from the machine, not the server#7964Frooodle wants to merge 10 commits into
Frooodle wants to merge 10 commits into
Conversation
Contributor
🌐 TOML Translation Verification Summary🔄 Reference Branch:
|
Frooodle
marked this pull request as draft
September 12, 2026 19:11
Contributor
🚀 V2 Auto-Deployment Complete!🔗 Direct Test URL (non-SSL) http://54.175.155.236:7964 🧩 Admin portal included - try it at http://54.175.155.236:7964/portal. This deployment will be automatically cleaned up when the PR is closed. 🔄 Auto-deployed for approved V2 contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
getDownloadsDirectoryseam, instead of asking the server for a directory it cannot see.downloads-suggestionprobe, which no longer has a caller.Why: a remote server has no user Downloads folder — it answers
{"directory":"","available":false,"pdfCount":0}even under an Enterprise licence — so the offer never appeared on desktop at all.Not in scope: writing labelled bytes back to disk, and the wider processing-folder rework.
Stacked on
gate-desktop-premium-surfaces— so this PR's diff includes that branch's commits and its parent's.Open question for review: this duplicates the Downloads sweep in this PR's own base branch; the two should probably share one service.
Ran:
frontend:typecheck:all,frontend:lint,frontend:format:check, fullvitest,comment-lint.Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)
task checkto verify linters, typechecks, and tests pass