Reconcile policies again when the signed-in user changes - #7966
Draft
Frooodle wants to merge 1 commit into
Draft
Conversation
Contributor
🚀 V2 Auto-Deployment Complete!🔗 Direct Test URL (non-SSL) http://54.175.155.236:7966 🧩 Admin portal included - try it at http://54.175.155.236:7966/portal. This deployment will be automatically cleaned up when the PR is closed. 🔄 Auto-deployed for approved V2 contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
usePoliciesreconciled only on mount, so a fetch that ran before there was a session left every category in its unconfigured default.policyStorage.defaultState()returns exactly the same shape.Why: reproduced on a real desktop install — the Policies page read the backend live and showed Classification enabled, while the app's own cache said unconfigured and nothing classified.
Scope: shared policy plumbing, so it affects web and SaaS as well as desktop. Independent of the other desktop PRs.
Known remaining: the cache still cannot express "unknown" versus "off". This removes the common cause rather than the conflation itself.
Ran:
frontend:typecheck:all,frontend:lint,frontend:format:check, fullvitest(3440),comment-lint.Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)
task checkto verify linters, typechecks, and tests pass