-
Notifications
You must be signed in to change notification settings - Fork 32
Add Spotify Control Plugin #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rene Lüllau <[email protected]>
|
Great work - thank you! I don't have Spotify Premium (only Tidal), so unfortunately, I can't do a complete test - but that's not a problem. What I noticed though, that directly after installation I got this Because I forgot to copy the attribute error the first time, I reinstalled the plugin to capture it for you, but this time also restarting didn't solve it. Weird... And I also changed the PR in the json as it should be the version of the app, not of the plugin. This not very well explained in the docs, I'll change that. |
|
Thank you for the short test. I moved the assigning of the _settings_manager at the beginning of the main.py init function. Maybe there was a timing problem. |
|
Well, I was too quick just moving the assignment of the _settings_manager to the top. Then some functions from the backend and actions are missing. I moved it back. In the next version my Main focus is optimization and fixing bugs anyway so I will take care of that too. |
|
Ok, please just update the commit hash in the json and ping me, once you found a solution. |
Signed-off-by: Rene Lüllau <[email protected]>
|
@Core447 I think I fixed the problem. Just the settings manager now gets initialized before the actions. |
|
Great! Thank you! |
|
What's your name on dc? Then I can tag you in the release annoucement |
|
It's K!ll3rT. |
👍️. Seems like there's another person on the discord with the same name. Hope I got the right one. Otherwise let me know |
|
You got the right one. I am both One is my Old account I got the password again and the other is my new but now abandoned account. |
Ah, ok. Got it |
Checks