Skip to content

Conversation

@ReneLu
Copy link
Contributor

@ReneLu ReneLu commented May 3, 2025

Checks

Rene Lüllau and others added 2 commits May 3, 2025 02:32
@Core447
Copy link
Member

Core447 commented May 3, 2025

Great work - thank you!

I don't have Spotify Premium (only Tidal), so unfortunately, I can't do a complete test - but that's not a problem.

What I noticed though, that directly after installation I got this AttributeError: 'SpotifyControl' object has no attribute '_settings_manager' error when trying to open the plugin settings in l.109 of your main.py.
After a restart of the app this error was gone, but instead I got an error because an empty string (the stored port) couldn't be converted into an int.

Because I forgot to copy the attribute error the first time, I reinstalled the plugin to capture it for you, but this time also restarting didn't solve it. Weird...

And I also changed the PR in the json as it should be the version of the app, not of the plugin. This not very well explained in the docs, I'll change that.

@ReneLu
Copy link
Contributor Author

ReneLu commented May 3, 2025

Thank you for the short test. I moved the assigning of the _settings_manager at the beginning of the main.py init function. Maybe there was a timing problem.
Also the default value for the port was set to an empty string. I have set it to 8080.

@ReneLu
Copy link
Contributor Author

ReneLu commented May 3, 2025

Well, I was too quick just moving the assignment of the _settings_manager to the top. Then some functions from the backend and actions are missing. I moved it back. In the next version my Main focus is optimization and fixing bugs anyway so I will take care of that too.

@Core447
Copy link
Member

Core447 commented May 5, 2025

Ok, please just update the commit hash in the json and ping me, once you found a solution.

@ReneLu
Copy link
Contributor Author

ReneLu commented May 5, 2025

@Core447 I think I fixed the problem. Just the settings manager now gets initialized before the actions.
I tested it by removing the plugin, restarting the stream controller and then installing it again. I had no Error messages in the logs.
I Updated the commit ID in the store.

@Core447
Copy link
Member

Core447 commented May 6, 2025

Great! Thank you!

@Core447 Core447 merged commit fb288eb into StreamController:main May 6, 2025
1 check passed
@Core447
Copy link
Member

Core447 commented May 6, 2025

What's your name on dc? Then I can tag you in the release annoucement

@ReneLu
Copy link
Contributor Author

ReneLu commented May 6, 2025

It's K!ll3rT.

@Core447
Copy link
Member

Core447 commented May 7, 2025

It's K!ll3rT.

👍️. Seems like there's another person on the discord with the same name. Hope I got the right one. Otherwise let me know

@ReneLu
Copy link
Contributor Author

ReneLu commented May 7, 2025

You got the right one. I am both One is my Old account I got the password again and the other is my new but now abandoned account.

@Core447
Copy link
Member

Core447 commented May 8, 2025

You got the right one. I am both One is my Old account I got the password again and the other is my new but now abandoned account.

Ah, ok. Got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants