Skip to content

fix: resolve 21 lint errors#10

Merged
james-cross merged 2 commits intomainfrom
staging
Mar 13, 2026
Merged

fix: resolve 21 lint errors#10
james-cross merged 2 commits intomainfrom
staging

Conversation

@camlambert2000
Copy link
Collaborator

Fixes all 21 errors flagged by the tightened lint rules James added. Grouped by type:

  • no-unused-vars (12): removed dead code (profileFieldToGate, safeguardingExit, shouldAskSocialServicesQuestions, followup), prefixed required unused args, removed unused imports
  • no-explicit-any (4): proper interfaces added in postcodeResolver.ts and phrasebank.ts
  • no-misused-promises (2): async event handlers wrapped in ChatInterface.tsx
  • no-useless-escape (2): unnecessary escapes removed from regex in postcodeResolver.ts
  • no-shadow (1): inner la variable renamed to laKey in stateMachine.ts

72 tests passing. npm run check returns 0 errors.

🤖 Generated with Claude Code

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
street-support-va-staging Ready Ready Preview, Comment Mar 13, 2026 9:35pm
streetsupport-platform-va Ready Ready Preview, Comment Mar 13, 2026 9:35pm

Request Review

…handling)

- Remove unused imports (PhraseEntry, UserProfile), functions
  (safeguardingExit, shouldAskSocialServicesQuestions), and variables
  (profileFieldToGate, PostcodeResult, followupOptions, followup)
- Replace explicit any with proper interfaces (EndpointEntry, DVLocalOrg)
- Wrap async event handlers to satisfy no-misused-promises
- Remove useless regex escapes, rename shadowed variable (la -> laKey)
- Prefix required-but-unused params (_choice, _session)
@james-cross james-cross merged commit 2850b6c into main Mar 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants