Fix SeaTreader_SetNextPathPoint not emitting metadata changes #2290
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Modification looks good, are there any IG tests clearly showcasing the improvement ? |
|
Should this method be suppressed if it does not have any lock or does this not matter? |
This is possible to pull off via 2 methods, our current suppression logic or some reflection shenanigans that targets all uses of that method and replaces them with a nop instruction or just removes it entirely, whichever is easiest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some internal metadata of the SeaTreader are modified inside the method, we should extract and send metadata changes after this method is called