Conversation
Author
|
This should fix #3 . |
|
this is a great idea - we have been having rate limiting issues trying to build something on top of this sdk. It would be great to have this fixed inside the python sdk |
Contributor
|
Actually request library itself implements exponential backoff we need to pass few parameters to it. Though the solution looks good any specific reason for creating the custom backoff function instead of using builtin solution https://www.peterbe.com/plog/best-practice-with-retries-with-requests |
Author
|
Oh cool. Happy to go with whatever Sumo team prefer. |
|
Looking at implementing an API client integration with this library - any prospects for having this bumped/merged soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements exponential backoff for all Sumologic API calls.
There is also a fix for the endpoint patch that made its way in recently that didn't seem to be tested properly (ping @mccartney), this and a whitespace fix are in separate commits, hope that's OK.
Cheers
Jarrad