Migrate fetch-twitch-subscriber-list to Typescript#104
Open
boring-nick wants to merge 2 commits intoSupinic:masterfrom
Open
Migrate fetch-twitch-subscriber-list to Typescript#104boring-nick wants to merge 2 commits intoSupinic:masterfrom
boring-nick wants to merge 2 commits intoSupinic:masterfrom
Conversation
Supinic
requested changes
Sep 20, 2024
| @@ -1,23 +1,41 @@ | |||
| import { Error as SupiError } from "supi-core"; | |||
| import sharedKeys from "../../utils/shared-cache-keys.json" with { type: "json" }; | |||
| import { sb } from "../../@types/globals.js"; | |||
Owner
There was a problem hiding this comment.
This is not going to work due to:
- The file targeted is
globals.jsbut the original file isglobals.d.ts - The
directory is not included in./build` so the import will fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.