Skip to content
This repository was archived by the owner on Jul 21, 2025. It is now read-only.

fix: fixed ridiculous errors #20

Open
monkey96 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fixed ridiculous errors #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 33 additions & 52 deletions lib/dart_debug_sample.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,70 +1,51 @@
import 'package:intl/intl.dart';

class YukymController {

// DateTime.parse(_userData.value!.selectDate)
String nowDate = DateFormat('yyyy-mm-dd').format(DateTime.now());
String nowDate = DateFormat('yyyy-MM-dd').format(DateTime.now());

late String nowTime;

// 1. 자시의 국 : 갑자1국 = getTyOne()의 값
String getTyA() {
List<YukymTimeModel> timeDataOne =
_getTimeDataOne(nowDate);

if (timeDataOne.isNotEmpty) {
nowTime = timeDataOne.first.ty1;
// List<YukymTimeModel> timeDataOne = _getTimeDataOne(nowDate);
nowTime = YukymTimeModel().ty1; // 왜있는지는 모르겠지만 아무튼 nowTime에는 계속 넣고있던 값을 넣어봄

final month = nowDate.substring(5, 7);
if (month == '01' || month == '02') {
return '경오1국';
} else if (month == '03' || month == '04') {
return '경오2국';
} else if (month == '05' || month == '06') {
return '경오3국';
} else if (month == '07' || month == '08') {
return '경오4국';
} else if (month == '09' || month == '10') {
return '경오5국';
} else if (month == '11' || month == '12') {
return '경오6국';
}
return nowTime;
} else {
// Handle the case when the list is empty
return '경오7국'; // Or any other appropriate action
}
final month = DateTime.now().month;
return '경오${(month / 2).ceil()}국';
}
Comment on lines 10 to 16
Copy link

@coderabbitai coderabbitai bot Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

사용되지 않는 변수 할당을 제거하세요.

nowTime 변수에 값을 할당하고 있지만 반환 로직에서 사용하지 않습니다. 또한 주석 처리된 코드는 제거하는 것이 좋겠습니다.

다음과 같이 수정하는 것을 제안합니다:

  String getTyA() {
-    // List<YukymTimeModel> timeDataOne = _getTimeDataOne(nowDate);
-    nowTime = YukymTimeModel().ty1; // 왜있는지는 모르겠지만 아무튼 nowTime에는 계속 넣고있던 값을 넣어봄
-
    final month = DateTime.now().month;
    return '경오${(month / 2).ceil()}국';
  }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
String getTyA() {
List<YukymTimeModel> timeDataOne =
_getTimeDataOne(nowDate);
if (timeDataOne.isNotEmpty) {
nowTime = timeDataOne.first.ty1;
// List<YukymTimeModel> timeDataOne = _getTimeDataOne(nowDate);
nowTime = YukymTimeModel().ty1; // 왜있는지는 모르겠지만 아무튼 nowTime에는 계속 넣고있던 값을 넣어봄
final month = nowDate.substring(5, 7);
if (month == '01' || month == '02') {
return '경오1국';
} else if (month == '03' || month == '04') {
return '경오2국';
} else if (month == '05' || month == '06') {
return '경오3국';
} else if (month == '07' || month == '08') {
return '경오4국';
} else if (month == '09' || month == '10') {
return '경오5국';
} else if (month == '11' || month == '12') {
return '경오6국';
}
return nowTime;
} else {
// Handle the case when the list is empty
return '경오7국'; // Or any other appropriate action
}
final month = DateTime.now().month;
return '경오${(month / 2).ceil()}국';
}
String getTyA() {
final month = DateTime.now().month;
return '경오${(month / 2).ceil()}국';
}
🤖 Prompt for AI Agents 
In lib/dart_debug_sample.dart around lines 10 to 16, the variable nowTime is
assigned a value but never used, and there is commented-out code that should be
removed. Remove the assignment to nowTime and delete the commented-out line to
clean up unused code and improve readability.


String getTyB() {
List<YukymTimeModel> timeDataOne =
_getTimeDataOne(nowDate);
List<YukymTimeModel> timeDataOne = _getTimeDataOne(nowDate);
String result = timeDataOne.first.ty12;

final nowTime = DateTime.now();
if (nowTime.hour >= 0 || nowTime.hour < 2) {
return timeDataOne.first.ty1;
} else if (nowTime.hour >= 4 || nowTime.hour < 6) {
return timeDataOne.first.ty2;
} else if (nowTime.hour >= 6 || nowTime.hour < 8) {
return timeDataOne.first.ty3;
} else if (nowTime.hour >= 8 || nowTime.hour < 10) {
return timeDataOne.first.ty4;
} else if (nowTime.hour >= 10 || nowTime.hour < 12) {
return timeDataOne.first.ty5;
} else if (nowTime.hour >= 12 || nowTime.hour < 14) {
return timeDataOne.first.ty6;
} else if (nowTime.hour >= 16 || nowTime.hour < 18) {
return timeDataOne.first.ty7;
} else if (nowTime.hour >= 18 || nowTime.hour < 20) {
return timeDataOne.first.ty8;
} else if (nowTime.hour >= 20 || nowTime.hour < 22) {
return timeDataOne.first.ty9;
} else if (nowTime.hour >= 22 || nowTime.hour < 24) {
return timeDataOne.first.ty10;
}
final nowHour = DateTime.now().hour;

return result;
return '갑자${(nowHour / 2).toInt()}국';

// if (nowTime.hour >= 0 && nowTime.hour < 2) {
// return timeDataOne.first.ty1;
// } else if (nowTime.hour >= 4 && nowTime.hour < 6) {
// return timeDataOne.first.ty2;
// } else if (nowTime.hour >= 6 && nowTime.hour < 8) {
// return timeDataOne.first.ty3;
// } else if (nowTime.hour >= 8 || nowTime.hour < 10) {
// return timeDataOne.first.ty4;
// } else if (nowTime.hour >= 10 || nowTime.hour < 12) {
// return timeDataOne.first.ty5;
// } else if (nowTime.hour >= 12 || nowTime.hour < 14) {
// return timeDataOne.first.ty6;
// } else if (nowTime.hour >= 16 || nowTime.hour < 18) {
// return timeDataOne.first.ty7;
// } else if (nowTime.hour >= 18 || nowTime.hour < 20) {
// return timeDataOne.first.ty8;
// } else if (nowTime.hour >= 20 || nowTime.hour < 22) {
// return timeDataOne.first.ty9;
// } else if (nowTime.hour >= 22 || nowTime.hour < 24) {
// return timeDataOne.first.ty10;
// }

// return result;
}
Comment on lines 18 to 49
Copy link

@coderabbitai coderabbitai bot Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

사용되지 않는 코드와 변수를 정리하세요.

여러 가지 문제점이 있습니다:

  1. timeDataOne 리스트를 생성하지만 사용하지 않습니다
  2. result 변수를 할당하지만 사용하지 않습니다
  3. 대량의 주석 처리된 코드가 있습니다

다음과 같이 정리하는 것을 제안합니다:

  String getTyB() {
-    List<YukymTimeModel> timeDataOne = _getTimeDataOne(nowDate);
-    String result = timeDataOne.first.ty12;
-
    final nowHour = DateTime.now().hour;
    return '갑자${(nowHour / 2).toInt()}국';
-
-    // if (nowTime.hour >= 0 && nowTime.hour < 2) {
-    //   return timeDataOne.first.ty1;
-    // } else if (nowTime.hour >= 4 && nowTime.hour < 6) {
-    //   return timeDataOne.first.ty2;
-    // } else if (nowTime.hour >= 6 && nowTime.hour < 8) {
-    //   return timeDataOne.first.ty3;
-    // } else if (nowTime.hour >= 8 || nowTime.hour < 10) {
-    //   return timeDataOne.first.ty4;
-    // } else if (nowTime.hour >= 10 || nowTime.hour < 12) {
-    //   return timeDataOne.first.ty5;
-    // } else if (nowTime.hour >= 12 || nowTime.hour < 14) {
-    //   return timeDataOne.first.ty6;
-    // } else if (nowTime.hour >= 16 || nowTime.hour < 18) {
-    //   return timeDataOne.first.ty7;
-    // } else if (nowTime.hour >= 18 || nowTime.hour < 20) {
-    //   return timeDataOne.first.ty8;
-    // } else if (nowTime.hour >= 20 || nowTime.hour < 22) {
-    //   return timeDataOne.first.ty9;
-    // } else if (nowTime.hour >= 22 || nowTime.hour < 24) {
-    //   return timeDataOne.first.ty10;
-    // }
-
-    // return result;
  }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
String getTyB() {
List<YukymTimeModel> timeDataOne =
_getTimeDataOne(nowDate);
List<YukymTimeModel> timeDataOne = _getTimeDataOne(nowDate);
String result = timeDataOne.first.ty12;
final nowTime = DateTime.now();
if (nowTime.hour >= 0 || nowTime.hour < 2) {
return timeDataOne.first.ty1;
} else if (nowTime.hour >= 4 || nowTime.hour < 6) {
return timeDataOne.first.ty2;
} else if (nowTime.hour >= 6 || nowTime.hour < 8) {
return timeDataOne.first.ty3;
} else if (nowTime.hour >= 8 || nowTime.hour < 10) {
return timeDataOne.first.ty4;
} else if (nowTime.hour >= 10 || nowTime.hour < 12) {
return timeDataOne.first.ty5;
} else if (nowTime.hour >= 12 || nowTime.hour < 14) {
return timeDataOne.first.ty6;
} else if (nowTime.hour >= 16 || nowTime.hour < 18) {
return timeDataOne.first.ty7;
} else if (nowTime.hour >= 18 || nowTime.hour < 20) {
return timeDataOne.first.ty8;
} else if (nowTime.hour >= 20 || nowTime.hour < 22) {
return timeDataOne.first.ty9;
} else if (nowTime.hour >= 22 || nowTime.hour < 24) {
return timeDataOne.first.ty10;
}
final nowHour = DateTime.now().hour;
return result;
return '갑자${(nowHour / 2).toInt()}국';
// if (nowTime.hour >= 0 && nowTime.hour < 2) {
// return timeDataOne.first.ty1;
// } else if (nowTime.hour >= 4 && nowTime.hour < 6) {
// return timeDataOne.first.ty2;
// } else if (nowTime.hour >= 6 && nowTime.hour < 8) {
// return timeDataOne.first.ty3;
// } else if (nowTime.hour >= 8 || nowTime.hour < 10) {
// return timeDataOne.first.ty4;
// } else if (nowTime.hour >= 10 || nowTime.hour < 12) {
// return timeDataOne.first.ty5;
// } else if (nowTime.hour >= 12 || nowTime.hour < 14) {
// return timeDataOne.first.ty6;
// } else if (nowTime.hour >= 16 || nowTime.hour < 18) {
// return timeDataOne.first.ty7;
// } else if (nowTime.hour >= 18 || nowTime.hour < 20) {
// return timeDataOne.first.ty8;
// } else if (nowTime.hour >= 20 || nowTime.hour < 22) {
// return timeDataOne.first.ty9;
// } else if (nowTime.hour >= 22 || nowTime.hour < 24) {
// return timeDataOne.first.ty10;
// }
// return result;
}
String getTyB() {
final nowHour = DateTime.now().hour;
return '갑자${(nowHour / 2).toInt()}국';
}
🤖 Prompt for AI Agents 
In lib/dart_debug_sample.dart between lines 18 and 49, the method getTyB creates
the timeDataOne list and assigns a value to the result variable but never uses
them, and it contains a large block of commented-out code. Remove the unused
timeDataOne list and result variable declarations, and delete the commented-out
code to clean up the method, leaving only the necessary logic that returns the
formatted string based on nowHour.


List<YukymTimeModel> _getTimeDataOne(String nowDate) {
Expand All @@ -89,4 +70,4 @@ class YukymTimeModel {
String ty10 = '갑자10국';
String ty11 = '갑자11국';
String ty12 = '갑자12국';
}
}
5 changes: 1 addition & 4 deletions test/dart_debug_sample_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import 'package:dart_debug_sample/dart_debug_sample.dart';
import 'package:test/test.dart';

void main() {
test('', () {

});
test('', () {});
}