Controller backend improvements #4552
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RetroEdit
force-pushed
the
Controller-backend-improve
branch
from
f032f19 to
7ccee8c
Compare
YoshiRulz
reviewed
Nov 22, 2025
| /// Currently only returns 0 for consoles where all control ports are empty, | ||
| /// so returns 1 for (non-linked) Game Boy and similar cases. | ||
| /// </summary> | ||
| public int PlayerCount |
Member
There was a problem hiding this comment.
Where is this used? Would it not be better to change the semantics such that player 0 counts as a player (that is, PlayerCount is usually 1 more than the number of plugged-in gamepads)?
Contributor
Author
There was a problem hiding this comment.
I'll look and consider it. I'm not sure I entirely like the semantics of treating the console itself as a "player" though. At that point, I would also question why one couldn't just get the length of ControlsOrdered directly.
Collaborator
There was a problem hiding this comment.
Well ControlsOrdered relies on PlayerCount to know how many control groups there are. I do think documenting the special behavior is not useful when it should be changed instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4550
Check if completed: