Add livetime and elut correction#222
Draft
samaloney wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 85.29% 76.16% -9.13%
==========================================
Files 50 50
Lines 3175 3293 +118
==========================================
- Hits 2708 2508 -200
- Misses 467 785 +318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jajmitchell
reviewed
Apr 28, 2026
jajmitchell
left a comment
jajmitchell
left a comment
There was a problem hiding this comment.
I took a quick look through and the only thing I could see that needs adding in is the livetime error
|
|
||
| if livetime_correction: | ||
| lt = self.livetime_fraction[:, : counts.shape[1]].reshape(counts.shape[0], counts.shape[1], 1, 1) | ||
| counts = counts / lt |
There was a problem hiding this comment.
Need to add in livetime uncertainty calculation by calculating livetime_upper and livetime_lower
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.