fix: use getattr for sglang_speculative_algorithm to avoid AttributeError#1913
Open
none0663 wants to merge 1 commit into
Open
fix: use getattr for sglang_speculative_algorithm to avoid AttributeError#1913none0663 wants to merge 1 commit into
none0663 wants to merge 1 commit into
Conversation
…rror When sglang args are not parsed (e.g. debug_train_only mode), the args namespace does not have the sglang_speculative_algorithm attribute, causing an AttributeError in _compute_spec_metrics. Using getattr with a default of None safely handles both cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sglang args are not parsed (e.g. debug_train_only mode), the args namespace does not have the sglang_speculative_algorithm attribute, causing an AttributeError in _compute_spec_metrics. Using getattr with a default of None safely handles both cases.
