Add Stream Reactions - #1565
Open
SebiWrn wants to merge 66 commits into
Open
Conversation
kordianbruck
previously requested changes
Jun 5, 2025
Merged
Tested: the string version is different that the one in db. It's also messy. So the normal version is used as it gets formatted automatically. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Correct, in api/stream_reactions.go we use streamId. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Cleaner api design. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
coolgirl19
requested changes
Jun 27, 2026
coolgirl19
left a comment
coolgirl19
left a comment
Contributor
There was a problem hiding this comment.
With the help of Copilot, I avoided the lock on the stream reactions object, which otherwise could have blocked other reactions from coming in. @Mazi02, please take a look at whether it makes sense; you can revert it otherwise. Is there any way for a user to know if their reaction has been rejected because of a cool-down period?
Mazi02
approved these changes
Jun 27, 2026
Co-authored-by: coolgirl19 <35705443+coolgirl19@users.noreply.github.com>
Contributor
|
@coolgirl19 regarding the user notification I am going to make a notification pop up for it. |
Contributor
|
@Mazi02 can this be reviewed again? |
Contributor
|
@alexanderstephan yes I am done with the final touches, though I would like to have the @coolgirl19 to look over it too and if she agrees we can merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This pull request adds previously mentioned reactions by students (look at #1564).
Closes #127.
The percentage below the reactions shows the usage in the last few minutes.
Available reactions can be modified in the config.yaml.
Important
Do not merge before #1564 !!
Screenshots