セイクリッドピラーの1.21.4移植 #994
Open
セイクリッドピラーの1.21.4移植 #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケット URL
GH-933
対応内容・対応背景・妥協点
セイクリッドピラーを1.21.4に移植した
やったこと
サウンドソースの変更
returnコマンドを追加し、store successを原バージョンに対応
attribute名を
minecraft:max_healthにテスト
セイクリッドピラーが敵に命中したとき、効果時間が減少するのを確認
レビュー観点
想定通りに動作するか
チェックリスト (ガイドライン)