-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poetry dependency manager and package builder #368
Open
tintin10q
wants to merge
25
commits into
TagStudioDev:main
Choose a base branch
from
tintin10q:add-poetry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
713ea54
Added poetry stuff to pyproject.toml
tintin10q cbbc453
Adding src to the path fixes the console_script and poetry run tagstu…
tintin10q cd2dfb2
Lazy import the ui modes. Also this fixes cli not being included in t…
tintin10q 08dd179
For poetry to work resources has to be an importable package
tintin10q ef51164
Add __init__.py to make tagstudio a package
tintin10q 32e9c07
Add __init__.py to package
tintin10q a2f9b7c
Put packages on multiple lines
tintin10q bb8558c
Update tagstudio/__init__.py
tintin10q 825af51
Shorter pypackage.toml description
tintin10q 62df241
Added tests to package build
tintin10q 78af477
Included tests in the release package
tintin10q b5fd573
Removed duplicate readme tag
tintin10q 3cc87cf
Add poetry.lock file to vsc
tintin10q 6f2004a
Ruff suggestions
tintin10q a06e90d
Update CONTRIBUTING.md with poetry instructions
tintin10q 945b20c
Changed supported python version from just 3.12 to also 3.11
tintin10q f98d2f6
Bumped version to the actual version of 9.3.2
tintin10q 15e427e
Merge branch 'main' into add-poetry
tintin10q 3b24911
Small word repetition fix
tintin10q 97c7337
Update pyproject.toml
tintin10q e8f66a9
Unupdate changes to pyproject.toml
tintin10q f59ad99
Added explanation text to CONTRIBUTING.md about how to add and remove…
tintin10q f561374
Specify where to run poetry install command.
tintin10q 4a69f11
Merge remote-tracking branch 'origin/main' into add-poetry
tintin10q 4b82769
Move adding the package to the import path into __init__.py
tintin10q File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im in favor of sharing one way to install a tool if there is consensus to use it. I use poetry daily, there are many things I don't like about it, but it makes the interface we use the same for all developers, no matter what platform you are on.
Currently the recommended way to install poetry is by using
pipx
this is a tool that is recommended for python devs to have, but it is yet another install process to document.Im happy write the changes needed if that is something you would like me to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear to me what changes you are actually suggesting here. @eivl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pipx install poetry
is the command to install poetry. the docs has multiple other ways to install it, but I'm in favor of front loading the information instead of back loading it with more links to click on.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so just adding
pipx install poetry
in CONTRIBUTING.md with some text?