-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add thumbnail caching #694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18b5db0
to
f126036
Compare
This change allows for modified files to have their cached thumbnail regenerated.
TODO: Store this on a per-library basis and allow it to be configurable inside the program.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: High
An important issue requiring attention
Type: File System
File system interactions
Type: QoL
A quality of life (QoL) enhancement or suggestion
Type: UI/UX
User interface and/or user experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability for file thumbnails to be cached inside a new
thumbs
folder within a library's.TagStudio
directory. This cache used when possible to quickly update the thumbnails shown in the preview grid. Images in the Preview Panel still get rendered directly from their source files for maximum resolution. The main features of this process include:Known Issues
size
argumentAdditional Considerations (TODO)
Users should be able to clear the cache from inside the programThe program should be able to detect modified files and update the cache appropriatelyThe cache should probably have a size limitThere should be a way for the program to automatically clear old and/or orphaned thumbnailsCloses #104, Closes #345
NOTE: This PR is currently awaiting the merging of #647 in order to add the thumbnail cache options to the new settings config.