Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add configurable splash screens #703

Merged
merged 5 commits into from
Jan 23, 2025
Merged

feat(ui): add configurable splash screens #703

merged 5 commits into from
Jan 23, 2025

Conversation

CyanVoxel
Copy link
Member

Summary

This PR introduces a new configurable splash screen system which allows for the selection of multiple preset splash screens, as well as the ability to set up future ones in code without needing to bake in information such as copyright notices or version numbers.

As part of this PR I've reconfigured the the existing splash screen to work with this system, added a remastered version of the original splash screen, and finally added a configuration for an upcoming v9.5 splash screen.

image


NOTE: This PR is currently awaiting the merging of #647 in order to add the splash screen selection to the new settings config.

@CyanVoxel CyanVoxel added Type: UI/UX User interface and/or user experience Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request labels Jan 15, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Jan 15, 2025
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source code looks good just two notes from testing:

  • SPLASH_95 seems broken
  • on SPLASH_GOO the cyan text is partially on cyan background and therefore hard to read

@CyanVoxel
Copy link
Member Author

Source code looks good just two notes from testing:

  • SPLASH_95 seems broken

I've omitted the image for SPLASH_95 in this PR and plan on committing it at a later date, so presently it should fall back to a black image

  • on SPLASH_GOO the cyan text is partially on cyan background and therefore hard to read

There shouldn't be any cyan text or overlapping text on visually disruptive parts of the image, could you send a screenshot of what this looks like for you? The reference of how this splash should appear is in the PR description

@Computerdores
Copy link
Collaborator

Had the colors mixed up, but this is what it looks like:
image

@CyanVoxel
Copy link
Member Author

Had the colors mixed up, but this is what it looks like:

Thanks for the image, looks like I need to make some adjustments so that everything shows up the same (or similar enough) on different machines.

If you could, could you let me know the OS you tested this on, your monitor resolution, and your display scaling percentage (probably just 100% / 1.0 unless you're on a high resolution display)?

@Computerdores
Copy link
Collaborator

Win 10 22H2
1920x1080
100%

@CyanVoxel
Copy link
Member Author

It seems like it's directly related to the different default fonts Qt uses on different systems. Testing on Windows with different screen scaling settings all got me the same proportions as your screenshot.

I added some code that changes the point size of the font if it's detected to be Segoe UI so that it roughly matches the size used when originally designing this on macOS. There's probably going to be one or more extra cases that arise on Linux, but I may just need to fix those as case(s) come in since I'm unable to develop on that myself at the moment.

@CyanVoxel CyanVoxel added Status: Mergeable The code is ready to be merged and removed Status: Review Needed A review of this is needed labels Jan 19, 2025
@CyanVoxel
Copy link
Member Author

Thank you @Computerdores for the review!

@CyanVoxel CyanVoxel merged commit a02c43c into main Jan 23, 2025
10 checks passed
@CyanVoxel CyanVoxel deleted the splash-config branch January 23, 2025 00:03
@CyanVoxel CyanVoxel removed Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request Status: Mergeable The code is ready to be merged labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants