-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add configurable splash screens #703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source code looks good just two notes from testing:
- SPLASH_95 seems broken
- on SPLASH_GOO the cyan text is partially on cyan background and therefore hard to read
I've omitted the image for
There shouldn't be any cyan text or overlapping text on visually disruptive parts of the image, could you send a screenshot of what this looks like for you? The reference of how this splash should appear is in the PR description |
Thanks for the image, looks like I need to make some adjustments so that everything shows up the same (or similar enough) on different machines. If you could, could you let me know the OS you tested this on, your monitor resolution, and your display scaling percentage (probably just 100% / 1.0 unless you're on a high resolution display)? |
Win 10 22H2 |
It seems like it's directly related to the different default fonts Qt uses on different systems. Testing on Windows with different screen scaling settings all got me the same proportions as your screenshot. I added some code that changes the point size of the font if it's detected to be Segoe UI so that it roughly matches the size used when originally designing this on macOS. There's probably going to be one or more extra cases that arise on Linux, but I may just need to fix those as case(s) come in since I'm unable to develop on that myself at the moment. |
Thank you @Computerdores for the review! |
Summary
This PR introduces a new configurable splash screen system which allows for the selection of multiple preset splash screens, as well as the ability to set up future ones in code without needing to bake in information such as copyright notices or version numbers.
As part of this PR I've reconfigured the the existing splash screen to work with this system, added a remastered version of the original splash screen, and finally added a configuration for an upcoming v9.5 splash screen.
NOTE: This PR is currently awaiting the merging of #647 in order to add the splash screen selection to the new settings config.