-
-
Notifications
You must be signed in to change notification settings - Fork 445
feat(form-core): field meta isDefaultValue #1456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View your CI Pipeline Execution ↗ for commit 12b94be.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1456 +/- ##
==========================================
+ Coverage 88.96% 89.04% +0.07%
==========================================
Files 31 31
Lines 1396 1406 +10
Branches 353 359 +6
==========================================
+ Hits 1242 1252 +10
Misses 137 137
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
46c3a4b
to
105bc87
Compare
Since isDirty and isPristine are opposites, how about merging the two rows in the visualization? That could reduce the verticality of the image |
25ea789
to
0f1b4c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things to tweak but overall this will be a great addition!
0867eae
to
8542f79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're in a really good state and it's probably enough to merge, if we missed something or there's room for improvement we can collect more feedback and tackle that on another PR :)
Thank you for addressing all the comments!
Closes #1080 & #1081