Skip to content

feat(form-core): field meta isDefaultValue #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 8, 2025

Conversation

harry-whorlow
Copy link
Contributor

Closes #1080 & #1081

Copy link

nx-cloud bot commented Apr 25, 2025

View your CI Pipeline Execution ↗ for commit 12b94be.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 31s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-07 17:43:24 UTC

Copy link

pkg-pr-new bot commented Apr 25, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1456

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1456

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1456

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1456

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1456

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1456

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1456

commit: 12b94be

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (3fe66dd) to head (12b94be).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
+ Coverage   88.96%   89.04%   +0.07%     
==========================================
  Files          31       31              
  Lines        1396     1406      +10     
  Branches      353      359       +6     
==========================================
+ Hits         1242     1252      +10     
  Misses        137      137              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harry-whorlow harry-whorlow force-pushed the is-default-value branch 5 times, most recently from 46c3a4b to 105bc87 Compare April 30, 2025 14:54
@harry-whorlow harry-whorlow marked this pull request as ready for review May 1, 2025 08:05
@LeCarbonator
Copy link
Contributor

LeCarbonator commented May 1, 2025

Since isDirty and isPristine are opposites, how about merging the two rows in the visualization? That could reduce the verticality of the image

@harry-whorlow harry-whorlow force-pushed the is-default-value branch 2 times, most recently from 25ea789 to 0f1b4c3 Compare May 2, 2025 12:13
Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things to tweak but overall this will be a great addition!

Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're in a really good state and it's probably enough to merge, if we missed something or there's room for improvement we can collect more feedback and tackle that on another PR :)

Thank you for addressing all the comments!

@harry-whorlow harry-whorlow merged commit bfe231a into TanStack:main May 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isDirty should flip back to false when default values are equal
3 participants