-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: move solid-js to prod dep on devtools-core #5571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughMoved Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Developer
participant Vite as Vite Build
participant Rollup as Rollup/Bundler
participant NodeModules as node_modules
Note over Developer,Vite: Before
Developer->>Vite: build router-devtools-core
Vite->>Rollup: include bundledDeps ['solid-js','solid-js/web']
Rollup->>NodeModules: bundle `solid-js` and `solid-js/web`
Rollup-->>Vite: bundled artifacts
Note over Developer,Vite: After (this PR)
Developer->>Vite: build router-devtools-core
Vite->>Rollup: bundledDeps does NOT include solid-js
Rollup->>NodeModules: treat `solid-js` as regular dependency (external/normal resolution)
Rollup-->>Vite: artifacts without explicit bundling of solid-js
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 559a559
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-router-ssr-query
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
|
This is a fix for: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
packages/router-devtools-core/package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Use workspace:* protocol for internal dependencies in package.json files
Files:
packages/router-devtools-core/package.json
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: TanStack/router#0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.598Z
Learning: Applies to packages/{react-router,solid-router}/** : Implement React and Solid bindings/components only in packages/react-router/ and packages/solid-router/
|
Does this effectively revert the changes here? @benmccann , what do you think of this change? |
|
Yes, this reverts the bundling. I do agree that not bundling is better for solid users. However, that's less than 1% of users. And not bundling is worse for everyone else. So I think on balance that we're better off with the bundling. I included some stats about that in #5374 Is the concern with multiple copies of solid related to size or something else? |
|
I don't have the full context on the changes, @AlemTuzlak doses have way more info around it. From TanStack/devtools#183, it seems like the issue around multiple solid js version is not related to bundle size, but to have multiple version of solid-js within warnings in the console and could (from my limited solid-js architecture knowledge) cause issues.
I have doubts however if this is actually causing issues given we mount each devtools into it's own solid-js render tree
Are we talking only about npm install size? It shouldn't be in production (unless you use the devtools in production) |

Given vite only dedupe when a dependancy is an explicit dependancy, and not a peer dependancy, this lead to multiple solidjs version if you used other tanstack devtools
Summary by CodeRabbit