fix: re-export correctly #6489
Merged
fix: re-export correctly #6489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughRemoved the barrel re-export of Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
|
View your CI Pipeline Execution ↗ for commit 6565946
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/router-core/src/router.ts (1)
1-31: Fix import order to satisfy lint rule.
Place the externalisServerimport with the other external imports.🔧 Suggested fix
import { Store, batch } from '@tanstack/store' import { createBrowserHistory, parseHref } from '@tanstack/history' +import { isServer } from '@tanstack/router-core/isServer' import { createControlledPromise, decodePath, deepEqual, @@ } from './path' -import { isServer } from '@tanstack/router-core/isServer' import { createLRUCache } from './lru-cache'packages/router-core/src/load-matches.ts (1)
1-7: Fix import order to satisfy ESLint (import/order).
Line 7 is an external import and should be grouped with other externals before relative imports.♻️ Proposed fix
import { batch } from '@tanstack/store' import invariant from 'tiny-invariant' -import { createControlledPromise, isPromise } from './utils' -import { isNotFound } from './not-found' -import { rootRouteId } from './root' -import { isRedirect } from './redirect' import { isServer } from '@tanstack/router-core/isServer' +import { createControlledPromise, isPromise } from './utils' +import { isNotFound } from './not-found' +import { rootRouteId } from './root' +import { isRedirect } from './redirect'
🤖 Fix all issues with AI agents
In `@packages/router-core/src/scroll-restoration.ts`:
- Around line 1-3: The import order violates the lint rule: move the external
import isServer (from '@tanstack/router-core/isServer') before the local imports
functionalUpdate (from './utils') and the type AnyRouter (from './router') so
external imports precede local ones; update the import statements accordingly to
ensure the external symbol isServer appears above the local symbols
functionalUpdate and AnyRouter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.