-
-
Notifications
You must be signed in to change notification settings - Fork 48
fix(react): date compare in shallow equal function #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Nice! This is a great fix. Can we apply the same fix to the other frameworks with similar |
View your CI Pipeline Execution ↗ for commit 4fb8437.
☁️ Nx Cloud last updated this comment at |
@tanstack/angular-store
@tanstack/react-store
@tanstack/store
@tanstack/solid-store
@tanstack/svelte-store
@tanstack/vue-store
commit: |
Hi, |
@crutchcorn any chance this can be merged? |
@@ -61,6 +61,11 @@ export function shallow<T>(objA: T, objB: T) { | |||
return true | |||
} | |||
|
|||
if (objA instanceof Date && objB instanceof Date) { | |||
if (objA.getTime() !== objB.getTime()) return false | |||
return true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: how about just return objA.getTime() === objB.getTime()
?
Hello, any updates on this? @lachlancollins |
Friendly bump, also interested in this. There is any need to work before it gets merged? |
Fix #160