Add reference scrypt parameter validation test#408
Draft
achimala wants to merge 1 commit into
Draft
Conversation
Add a small dedicated invalid-parameter test for the reference crypto_scrypt() implementation, covering zero r, zero p, and N == 1. Keep this outside tests/verify-strings since it does not verify ciphertext strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crypto_scrypt()implementationr, zerop, andN == 1tests/invalid-params/rather thantests/verify-strings/Dependency
This is intentionally opened as a draft because the test is expected to pass after the validation fixes in #406 and #407 are applied.
Tests
git diff --checkSplit out from #405.